-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for bug when providing superclass arguments as kwargs #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlcsilva
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton,
ethanwharris and
SeanNaren
as code owners
June 6, 2022 02:49
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
========================================
- Coverage 95% 71% -24%
========================================
Files 181 181
Lines 8051 8085 +34
========================================
- Hits 7620 5749 -1871
- Misses 431 2336 +1905 |
Signed-off-by: João Lourenço Silva <[email protected]>
Signed-off-by: João Lourenço Silva <[email protected]>
Borda
reviewed
Jun 6, 2022
Borda
approved these changes
Jun 7, 2022
justusschock
approved these changes
Jun 7, 2022
SkafteNicki
approved these changes
Jun 7, 2022
Thank you! @jlcsilva mind checking the typing inconsistency flagged by |
Thanks everyone! Didn't have the time to check the typing inconsistency earlier, but your fix looks good to me @Borda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1068
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃