Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metric collection missing update of property #1052

Merged
merged 3 commits into from
May 27, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 27, 2022

What does this PR do?

Fixes #1051

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label May 27, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone May 27, 2022
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1052 (ebd7079) into master (8263e27) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1052   +/-   ##
======================================
  Coverage      95%     95%           
======================================
  Files         181     181           
  Lines        8004    8007    +3     
======================================
+ Hits         7582    7585    +3     
  Misses        422     422           

@mergify mergify bot added the ready label May 27, 2022
@Borda Borda merged commit 0495862 into master May 27, 2022
@Borda Borda deleted the bugfix/metriccollection_update_count branch May 27, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of MetricCollection throws warnings that compute method was called before update.
2 participants