Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust metric state comparison #1022

Merged
merged 5 commits into from
May 13, 2022
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 10, 2022

What does this PR do?

Fixes bug found in discussion #1016
When searching for compute groups in metric collection we need to compare the states between metrics. torch.allclose is not robust to difference in dtype such as np.allclose (see issue pytorch/pytorch#55356). PR makes this comparison more robust.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label May 10, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #1022 (b3eece8) into master (6cffeb5) will decrease coverage by 0%.
The diff coverage is 86%.

@@          Coverage Diff           @@
##           master   #1022   +/-   ##
======================================
- Coverage      95%     95%   -0%     
======================================
  Files         180     180           
  Lines        7824    7828    +4     
======================================
  Hits         7431    7431           
- Misses        393     397    +4     

@mergify mergify bot added the ready label May 10, 2022
@Borda Borda enabled auto-merge (squash) May 10, 2022 16:11
@mergify mergify bot removed the has conflicts label May 12, 2022
@Borda Borda disabled auto-merge May 13, 2022 00:14
@Borda Borda merged commit 2b382d0 into master May 13, 2022
@Borda Borda deleted the bugfix/robust_compare_states branch May 13, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants