Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compute_on_step from detection #1005

Merged
merged 4 commits into from
May 5, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 4, 2022

What does this PR do?

Fixes part of #956

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the refactoring refactoring and code health label May 4, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #1005 (eb96614) into master (63094c2) will not change coverage.
The diff coverage is 0%.

❗ Current head eb96614 differs from pull request most recent head b8d1923. Consider uploading reports for the commit b8d1923 to get more accurate results

@@          Coverage Diff           @@
##           master   #1005   +/-   ##
======================================
  Coverage      71%     71%           
======================================
  Files         179     179           
  Lines        7656    7656           
======================================
  Hits         5420    5420           
  Misses       2236    2236           

@mergify mergify bot removed the has conflicts label May 5, 2022
@SkafteNicki SkafteNicki enabled auto-merge (squash) May 5, 2022 11:01
@mergify mergify bot added the has conflicts label May 5, 2022
@mergify mergify bot removed the has conflicts label May 5, 2022
@Borda Borda disabled auto-merge May 5, 2022 11:25
@Borda Borda merged commit 8137a35 into master May 5, 2022
@Borda Borda deleted the cleanup/compute_on_step_detection branch May 5, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants