Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect prims.copy_with_setitem to nvFuser's Executor #1676

Open
kevinstephano opened this issue Jan 22, 2025 · 0 comments
Open

Connect prims.copy_with_setitem to nvFuser's Executor #1676

kevinstephano opened this issue Jan 22, 2025 · 0 comments
Labels
enhancement New feature or request nvfuser

Comments

@kevinstephano
Copy link
Collaborator

kevinstephano commented Jan 22, 2025

🚀 Feature

def copy_with_setitem_meta(a: TensorProxy, index, value: TensorProxy) -> TensorProxy:
# TODO: port checks from clang, currently there because of the utilities they need
return TensorProxy(like=a)
copy_with_setitem = make_prim(PrimIDs.COPY_WITH_SETITEM, "copy_with_setitem", meta=copy_with_setitem_meta)

It would be good to connect prims.copy_with_setitem to nvFuser's executor. How is setitem supposed to be implemented?

Motivation

Would help reduce the exposure of Thunder overheads for the execution of individual operations.

cc @tfogal

@kevinstephano kevinstephano added enhancement New feature or request nvfuser labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nvfuser
Projects
None yet
Development

No branches or pull requests

1 participant