Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix use of jsonargparse avoiding reliance on non-public internal logic #1620

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix use of jsonargparse avoiding reliance on non-public internal logic #1620

merged 1 commit into from
Jun 27, 2023

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Jun 27, 2023

What does this PR do?

Fixes issues identified in #1564. More generally, this pull request changes flash_cli.py and lightning_cli.py such that they only use jsonargparse's public API.

closes #1564

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1620 (ed74d4c) into master (30bf0f5) will decrease coverage by 0%.
The diff coverage is 50%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1620   +/-   ##
======================================
- Coverage      86%     85%   -0%     
======================================
  Files         291     291           
  Lines       12876   12867    -9     
======================================
- Hits        11013   10990   -23     
- Misses       1863    1877   +14     

@mauvilsa mauvilsa marked this pull request as ready for review June 27, 2023 04:31
@Borda
Copy link
Member

Borda commented Jun 27, 2023

@mauvilsa awesome, thank you!

@Borda Borda added the enhancement New feature or request label Jun 27, 2023
@Borda Borda enabled auto-merge (squash) June 27, 2023 07:20
@Borda Borda merged commit ebe80e3 into Lightning-Universe:master Jun 27, 2023
@mauvilsa mauvilsa deleted the fix-jsonargparse-non-public branch June 27, 2023 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants