-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace load_boston
due to Ethical Issues
#629
Conversation
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
=======================================
Coverage 71.87% 71.87%
=======================================
Files 118 118
Lines 7146 7146
=======================================
Hits 5136 5136
Misses 2010 2010
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@koaning Hi, thank you for bringing this up and for providing the issue link. |
There are a number of replacements suggested in the linked issue, but as @koaning suggests, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for bringing this up. We are good to go once the tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the failing test is unrelated to the change in this PR. It's being fixed in #633. LGTM!
Let me check the failing tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the failing tests have been addressed in other PRs. LGTM!
What does this PR do?
This replaces the
load_boston
dataset withload_diabetes
. Theload_boston
dataset is up for removal from scikit-learn due to the ethical issues related to the variables in it. scikit-learn/scikit-learn#16155Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃