Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize file structure #50

Closed
Ligerx opened this issue May 22, 2019 · 0 comments · Fixed by #58
Closed

Reorganize file structure #50

Ligerx opened this issue May 22, 2019 · 0 comments · Fixed by #58

Comments

@Ligerx
Copy link
Owner

Ligerx commented May 22, 2019

After reading up on a bunch more examples, it makes a lot of sense to organize things by module basically. Every page/feature gets its own folder, no more separating related code into separate folders. eg. there's no reason for pages, containers, and components to be separated.

Keeping redux separate still does seem to make sense though. Technically it's all global state, but there are some that are explicitly global (eg. loading, error) and some are shared state between multiple pages.

I'm also not sold on the name features yet.. features, modules, pages, etc

https://github.com/markerikson/react-redux-links/blob/master/project-structure.md

features/
    library/
        index.js
        LibraryFilter.js
        LibraryHeader.js
        ...
    extensions/
        index.js
        ExtensionButton.js
        ExtensionListItem.js
        ...
redux/
    ...
types/
    ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant