-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate react-scripts to vite #577
Comments
do you have the |
I am using .env.development as follows and I don't have any issues with HMR. Reload works "blazingly fast"tm TSC_COMPILE_ON_ERROR=true
BROWSER=none
FAST_REFRESH=true
ESLINT_NO_DEV_ERRORS=true
HTTPS=false
REACT_EDITOR=vim
DISABLE_ESLINT_PLUGIN=true
DISABLE_NEW_JSX_TRANSFORM=false
# custom env vars
REACT_APP_PROXY_IP="localhost"
REACT_APP_PROXY_PORT="3000"
REACT_APP_WDYR=false |
@derneuere seems to think the dev experience isn't that great and there is an issue in the create-react-app repo, which matches this description. I've created a mr to disable es-lint during dev mode as that is one of the suggested fixes in the create-react-app repository. @derneuere , does this improve performance for you or does it remain the same? Is the variable |
I tried both changes. It looks like it now only need 2s instead of 8-10s on the first compile, but any following compile seems to be just as fast with or without linting. From my understanding, everything is way faster in vite. This would also cut down on build times, start up times etc. |
Describe the enhancement you'd like
Right now, the dev experience isn't great, because HMR is very slow. We can improve the experience by switching to vite instead.
The text was updated successfully, but these errors were encountered: