Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message in case of unknown array type #37

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

sk1p
Copy link
Member

@sk1p sk1p commented Mar 20, 2024

Fixes #36

@sk1p sk1p added the enhancement New feature or request label Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.52%. Comparing base (641cbd3) to head (85d7254).

❗ Current head 85d7254 differs from pull request most recent head 118d48a. Consider uploading reports for the commit 118d48a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   48.42%   48.52%   +0.10%     
==========================================
  Files           1        1              
  Lines         570      575       +5     
  Branches      121      122       +1     
==========================================
+ Hits          276      279       +3     
- Misses        276      277       +1     
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uellue
Copy link
Member

uellue commented Mar 20, 2024

LGTM, thx!

@uellue uellue merged commit ac9e8cd into LiberTEM:main Mar 20, 2024
15 checks passed
@sk1p sk1p deleted the get-backend-unknown branch March 20, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing behavior in get_backend w/ unknown types
2 participants