Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Remove typings? #15

Closed
ralphtheninja opened this issue Jun 23, 2018 · 5 comments
Closed

Remove typings? #15

ralphtheninja opened this issue Jun 23, 2018 · 5 comments
Assignees
@MeirionHughes
Labels
cleanup Housekeeping help wanted Extra attention is needed

Comments

@ralphtheninja
Copy link
Member

cc @MeirionHughes
@MeirionHughes MeirionHughes self-assigned this Jun 25, 2018
@juliangruber
Copy link
Member

what's the context for this?

@vweevers
Copy link
Member

@juliangruber most TypeScript typings are now housed in the Level/typings repo, until they stabilize, and then they'll be moved to DefinitelyTyped. See Level/community#16.

The open question here is whether @MeirionHughes has also moved the typings for errors to Level/typings. If so, we can remove them from errors.

@vweevers vweevers added the cleanup Housekeeping label Jan 1, 2019
@vweevers
Copy link
Member

vweevers commented Mar 2, 2019

@Level/typescript, cc @danwbyrne: Could you take a look at this, see what needs to happen? Are these typings used at all? Can/should they be moved to DT? Thanks!

@vweevers vweevers added the help wanted Extra attention is needed label Mar 2, 2019
@vweevers
Copy link
Member

We're bumping major anyway due to dropping node 9, so I went ahead and removed the typings (0ad3b37).

@danwbyrne
Copy link

Sorry for not getting back to you, I don't think the typings are used anywhere since they are on DT already. @vweevers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MeirionHughes MeirionHughes

Labels
cleanup Housekeeping help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@juliangruber @ralphtheninja @vweevers @MeirionHughes @danwbyrne