The client contributer example for Rust is wrong

[MarcCoquand]

Hi!

The example included for contributers is wrong:

use lemmy_api_common::post::{GetPosts, GetPostsResponse};
use lemmy_db_schema::{ListingType, SortType};
use ureq::Agent;

pub fn list_posts() -> GetPostsResponse {
    let params = GetPosts {
        type_: Some(ListingType::Local),
        sort: Some(SortType::New),
        ..Default::default()
    };
    Agent::new()
        .get("https://lemmy.ml/api/v3/post/list")
        .send_json(&params).unwrap()
        .into_json().unwrap()
}

It's a get request that sends a json body. If users try this example it won't fail, but they will find that changing sort and type does not work. An example that could be included for get requests:

use lemmy_api_common::post::{GetPostsResponse};

pub fn list_posts() -> GetPostsResponse {
    Agent::new()
        .get("https://lemmy.ml/api/v3/post/list")
        .query("sort", "Hot")
        .call()
        .unwrap()
        .into_json()
        .unwrap()
}

This one will work, and users are able to play around with it.

But might be a bit underwhelming as an example for those trying to learn.

[Nutomic]

Maybe its better to use reqwest for the example. Here is the equivalent code, would you make a pull request with that?

https://github.com/LemmyNet/lemmyBB/blob/main/src/api/post.rs#L23

https://github.com/LemmyNet/lemmyBB/blob/main/src/api/mod.rs#L81