Default Listing and Sort types not respected

[zacharee]

Jerboa Version
0.0.35

Describe the bug
I have the default Listing and Sort types set to Subscribed and TopDay respectively. When I open the app, I'm put on Local and Active.

My instance is sh.itjust.works, and I've tried resetting the app data and changing the settings to other values and back.

The settings are remembered correctly in the settings screen, but seem to be ignored.

To Reproduce
Steps to reproduce the behavior:

1. Go to Settings >> settings
2. Set "Default Listing Type" to Subscribed and "Default Sort Type" to TopDay.
3. Scroll down to the bottom and press "Save".
4. Close and reopen the app and it will go back to Local and Active.

[nahwneeth]

Fixed by #854

[kensand]

#854 has introduced a new bug for me - attempting to change the sort behavior or listing type on the HomeActivity loads the correct sort behavior/listing type for a moment and then reloads the home back to All/Active.

Reverting 058e3c3 fixes the issue for me, so I'm almost positive that is the cause.

Let me know if you'd prefer I open a new issue for this

[kensand]

Yup, I'm pretty sure the issue is that this line is called before loading the posts now, which just overwrites the potentially user-selected Sort/Type. How that gets remedied, I don't have an answer yet

[nahwneeth]

@kensand

I wasn't able to reproduce this. The line you've linked only runs during startup, account switch & sign out. I did find some potential rewrite of the defaults (& the other way - the defaults overwriting home filters). I have tried to addressed it in #817. Could you please confirm if that fixes your issues? If not, would appreciate if you provided more info on what actions were made after changing the settings.

Update: I was using the test account but was able to reproduce this in my personal account. I've opened a new issue #886 with logs. Just wanted to ask, is your email verified? As that might be the cause for settings not getting saved.

[kensand]

@nahwneeth I am verified - I pulled the latest commits and it seems to be working now - not sure what was happening, whether it be a glitch in the server's settings being saved or in Jerboa itself 🤷

[nahwneeth]

Hey, yeah I updated it to read from the local db. The changes you made will not sync with the server and will not carry over if you use a new device. (In most cases)

[MV-GH]

Should be fixed now