-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inbox reply interactions missing #525
Comments
Other folk are confirming on my post in c/Jerboa. |
Not a bug, a feature. Inbox interaction collapse needs to be added to 0.0.33 update documentation as it's not currently mentioned. |
The toggle for "show action bar by default fit comments" doesn't work for replies in your inbox. They're already collapsed by default regardless of the toggle. That's the real bug. |
It's a bit more than this as you can't show the controls at all currently. The only option you have is to press on the header of the inbox message that takes you to the top of the post that reply is buried in. |
This is not true, currently if you long press in the space beside the username it expands the action bar. |
Ah ha! You are correct but I could not figure this out and I thought I'd pressed everywhere that made sense at least. |
It took a bunch of us over in c/Jerboa the better part of an hour to figure it out, don't feel bad. |
For me it collapses the entire post, not just the action bar, which doesn't seem to cause this. Can you give the step-by-step process to reproduce this? I'm willing to look into fixing this, but I'm not sure how to reproduce. I think for now disabling the click next to the username while in the inbox makes the most sense, but I'm not sure if someone actually wants that feature. I use it a ton for collapsing comment threads, but not for inbox replies. |
For me the action bar is closed by default in the inbox regardless of how the toggle in the settings is set. Key for the image: Top White: Post Title For me, long pressing on the active area will expand and collapse the action bar. Tapping on the active area will collapse and expand the comment. If you collapse the comment while the action bar is expanded, the action bar is hidden with the comment but its expanded/collapsed state doesn't change. You can expand and collapse the action bar while the whole comment is collapsed, though you have to expand the comment to verify the state of the action bar. Note that this active area includes the comment time indicator but not the username. |
It took me about 6 tries after knowing how it was done to be able to get it to work. Basically press and hold. Bit tricky to do when you have sausage fingers. |
Ok, apparently my phone was stuck on an older version (0.0.32) for some reason. I can now reproduce it, so I'll work on a fix. It looks like the main issue is that the default behavior is as if the checkbox was checked, so probably just a miss in the new version migration or something. |
I tracked it down, looks like a really easy fix. My change merely fixes the default behavior here, you can still disable the action bar in the settings. Whether that's desired is a separate issue. |
** Jerboa Version **
0.0.33
Describe the bug
Buttons are missing below inbox rrplies
To Reproduce
Steps to reproduce the behavior:
The text was updated successfully, but these errors were encountered: