Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST AND QUESTION] : wait for recyled items ready before show #86

Open
chanphiromsok opened this issue Feb 4, 2025 · 4 comments

Comments

@chanphiromsok
Copy link

Thank you for creating such an awesome library! I was wondering if it would be possible to add an option like waitForItemRecycled before showing the items. This could help prevent jankiness during fast scrolling. What are your thoughts on this?
When scrolling too fast the items in the list recylcling seem overlap on each other

@michbil
Copy link
Contributor

michbil commented Feb 4, 2025

@chanphiromsok There are some ideas to avoid overlap in progress during fast scroll. One is #67 but it requires native module(and makes LegendList much closer to FlashList), another is pure JS algorithm which is still in discussion/prototyping phase. I tried some time ago just to wait until container is measured, but it hurts performance so much, so we are thinking about little bit smarter algorithm.
We will post our findings in this thread once we will know more.

@chanphiromsok
Copy link
Author

@chanphiromsok There are some ideas to avoid overlap in progress during fast scroll. One is #67 but it requires native module(and makes LegendList much closer to FlashList), another is pure JS algorithm which is still in discussion/prototyping phase. I tried some time ago just to wait until container is measured, but it hurts performance so much, so we are thinking about little bit smarter algorithm. We will post our findings in this thread once we will know more.

Wow that huge PR experiment hehehe

@jmeistrich
Copy link
Contributor

@chanphiromsok Can you share a video or even a code example if possible? It would be great to see the results you're seeing so we can make sure to optimize that case.

@chanphiromsok
Copy link
Author

@chanphiromsok Can you share a video or even a code example if possible? It would be great to see the results you're seeing so we can make sure to optimize that case.

https://youtube.com/shorts/NEEq7V75708?si=psa8aJe33cjrYY-2
currently the list when scroll is like video above you can see the heart icon seem order almost the same position when scroll fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants