Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-15017] Bugfix - Force Struct values order in EIP-712 messages #8473

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Nov 25, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Prevent errors on incorrectly ordered messages content

📝 Description

Struct content are now send via the type definition instead of the content directly, preventing errors when the struct is wrongly ordered.

Some test files have been shuffled to ensure the ordering is maintained now

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 25, 2024 4:53pm
native-ui-storybook ⬜️ Ignored (Inspect) Nov 25, 2024 4:53pm
react-ui-storybook ⬜️ Ignored (Inspect) Nov 25, 2024 4:53pm
web-tools ⬜️ Ignored (Inspect) Nov 25, 2024 4:53pm

@lambertkevin lambertkevin marked this pull request as ready for review November 25, 2024 16:53
@lambertkevin lambertkevin requested a review from a team as a code owner November 25, 2024 16:53
@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Nov 25, 2024
@lambertkevin lambertkevin merged commit 4fc1d7a into develop Nov 25, 2024
38 of 42 checks passed
@lambertkevin lambertkevin deleted the bugfix/force-struct-values-order-eip-712 branch November 25, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants