Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA-331][Detox] Implement CLI in Speculos test #8420

Merged
merged 3 commits into from
Nov 27, 2024
Merged

[QAA-331][Detox] Implement CLI in Speculos test #8420

merged 3 commits into from
Nov 27, 2024

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Nov 20, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • LLM Tests

📝 Description

Implement CLI in Speculos test :

  • Creating temporary userdata file for CLI modification
  • Fix minor issue for handling Speculos already used when not using Docker Desktop

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 10:05am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 10:05am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 10:05am
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 10:05am

@live-github-bot live-github-bot bot added mobile Has changes in LLM automation CI/CD stuff cli labels Nov 20, 2024
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_improve_detox_speculos branch from 161f7c1 to af7b3e3 Compare November 21, 2024 09:06
Base automatically changed from support/qaa_312_improve_detox_speculos to develop November 21, 2024 14:11
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_331_cli_detox_speculos branch 4 times, most recently from b2fbdfd to 2f98e98 Compare November 22, 2024 08:04
@live-github-bot live-github-bot bot removed the automation CI/CD stuff label Nov 22, 2024
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review November 22, 2024 08:06
@abdurrahman-ledger abdurrahman-ledger requested a review from a team as a code owner November 22, 2024 08:39
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_331_cli_detox_speculos branch 2 times, most recently from 5e98a49 to 4578480 Compare November 25, 2024 09:12
mcoursier-ledger
mcoursier-ledger approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@mcoursier-ledger mcoursier-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@VicAlbr VicAlbr merged commit 2f4b70c into develop Nov 27, 2024
53 checks passed
@VicAlbr VicAlbr deleted the support/qaa_331_cli_detox_speculos branch November 27, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VicAlbr VicAlbr VicAlbr approved these changes

@mcoursier-ledger mcoursier-ledger mcoursier-ledger approved these changes

@Wozacosta Wozacosta Wozacosta approved these changes

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
cli mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abdurrahman-ledger @Wozacosta @mcoursier-ledger @VicAlbr