Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow signing and showing addresses without registering policies, or without policies at all #43

Open
bigspider opened this issue May 10, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@bigspider
Copy link
Collaborator

bigspider commented May 10, 2022

Currently, for any wallet policy which is not one of the standard wallet policies, it is necessary to register it first, and then use the registration hmac in calls to get_wallet_address or sign_psbt.

It might be useful to allow unregistered (and unnamed) wallet policies, where the policy verification (similarly to the registration flow) is executed right before showing the address or signing a transaction, and no hmac is returned.
This is particularly useful since policies are not revocable, forcing registration when a one-time usage is desired could by itself be a security risk.

@bigspider bigspider added the enhancement New feature or request label May 10, 2022
@bigspider bigspider self-assigned this Jul 20, 2022
@bigspider bigspider changed the title Allow signing and showing addresses without registering policies Allow signing and showing addresses without registering policies, or without policies at all May 2, 2023
@bigspider
Copy link
Collaborator Author

As per the discussion in #153, there are some use cases that don't quite fit the "wallet policy" model (at least in the current version), yet it would be useful to be able to sign with keys controlled by the hardware wallet.

Without wallet policies, it might still be considered safe to sign with the internal keys if (for example) there is no change address and the user inspects all the outputs.

One concern mentioned in the discussion is that it would not be easy (or at all possible) to make sure that the UTXO being signed for does not belong to any of the registered wallet policies. As long as the UX makes it abundantly clear that it's not signing from a wallet policy, this might be acceptable. The policy-less signing could perhaps be disabled by default and only enabled with an explicit setting of the app.

@bigspider bigspider added this to the 2.1.3 milestone May 11, 2023
@bigspider bigspider modified the milestones: 2.1.3, 2.2.0 Jun 26, 2023
@bigspider bigspider removed this from the 2.2.0 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant