Correct _getExpandedVisibleBounds for Max Latitude #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid hiding markers above the Web Mercator projection maximum latitude (or below minimum latitude) whereas when the same markers are used outside MCG, Leaflet shows them at that limit.
Resolved issue with removeOutsideVisibleBoundsSpec test suite that covers the correction for maximum latitude. Also slightly improved comments of private method _checkBounds
Changed from _checkBounds to more descriptive _checkBoundsMaxLat.
danzel
added a commit
that referenced
this pull request
Oct 26, 2015
Correct _getExpandedVisibleBounds for Max Latitude
|
👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #512, created a new private method in MCG
_checkBoundsMaxLatthat corrects output of_getExpandedVisibleBoundswhen the latter reaches the CRS projection maximum latitude (typically for Web/Spherical Mercator).In that case, it extends the latitude to Infinity (or -Infinity in Southern hemisphere) so that all markers and clusters beyond the limit are added to the map. Indeed, when user adds markers directly to the map (not through MCG), if their latitude is above the limit, the projection will floor their position to the limit, so they will be visible within the map.
Without the correction, the map view bounds (even expanded) never reaches the very high latitudes, and MCG never adds markers and clusters at those positions. Hence they are never visible, even though they are counted as children of clusters at low zoom levels.
Also added 4 dedicated unit tests in removeOutsideVisibleBoundsSpec suite.