Skip to content
This repository has been archived by the owner on Mar 28, 2022. It is now read-only.

Add 'top' and 'bottom' directions. #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

connor
Copy link

@connor connor commented Nov 26, 2013

Possible fix for #47 (fyi @ryansit, @astetik).

Wanted to put this up and see what you thought. Some of the CSS could be cleaned up a bit.

screen shot 2013-11-26 at 12 56 32 am

What do you think?

@ryansit
Copy link

ryansit commented Nov 26, 2013

Like it!

@jacobtoye
Copy link
Member

Awesome work. I'll check it out later this week. Will need to check how well it interacts with the labelAnchor marker option and the L.Label offset options.

@ryansit
Copy link

ryansit commented Dec 1, 2013

Does this support auto top and bottom?

On Dec 1, 2013, at 10:36 AM, Jacob Toye [email protected] wrote:

Awesome work. I'll check it out later this week. Will need to check how well it interacts with the labelAnchor marker option and the L.Label offset options.


Reply to this email directly or view it on GitHub.

@connor
Copy link
Author

connor commented Dec 1, 2013

Cool, thanks @jacobtoye. I'm traveling today so I'll make the changes later this evening or tomorrow.

@ryansit - no, the existing auto logic is the same. Not sure what the desired behavior is or how we should set up the API to specify which direction the auto should fallback to, you know? Would love to hear some feedback if you have any strong feelings.

@ryansit
Copy link

ryansit commented Dec 1, 2013

I'm traveling too. Without diving into the code, right now there is left, right and auto. You added top bottom. Probably need autovertical that works like the other auto. The horiOntal auto seems to work with the middle point being the switch.

On Dec 1, 2013, at 11:38 AM, Connor Montgomery [email protected] wrote:

Cool, thanks @jacobtoye. I'm traveling today so I'll make the changes later this evening or tomorrow.

@ryansit - no, the existing auto logic is the same. Not sure what the desired behavior is or how we should set up the API to specify which direction the auto should fallback to, you know? Would love to hear some feedback if you have any strong feelings.


Reply to this email directly or view it on GitHub.

@fwitzke
Copy link

fwitzke commented Dec 18, 2013

+1 for this feature

adrianrego added a commit to adrianrego/Leaflet.label that referenced this pull request Feb 4, 2014
@MikeTommasi
Copy link

definitely would be nice to have.

@wattnpapa
Copy link

+1 for this feature!
Have someone start already the implementation?

@RobbieTheWagner
Copy link

This seems like something I could definitely use. I was looking into using Rrose to give me automatic positioning for marker popups, but this may work as well. Basically, I want the popup to determine its own direction that will not cause the map to pan when it pops up.

@jacobtoye
Copy link
Member

For popups I would use Leaflet.Rrose. This pull needs to be updated to get to a stage that it can be merged.

@tomasfejfar
Copy link

I'd really like this! 👍

@Taekjoon
Copy link

Taekjoon commented Nov 6, 2015

I want to add various label justification and rotation(angle) from the origin point together..

label_small

@gotvitch
Copy link

gotvitch commented Mar 9, 2016

Any update about this feature ?

@jasonbaik
Copy link

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.