-
Notifications
You must be signed in to change notification settings - Fork 224
Add 'top' and 'bottom' directions. #55
base: master
Are you sure you want to change the base?
Conversation
Like it! |
Awesome work. I'll check it out later this week. Will need to check how well it interacts with the |
Does this support auto top and bottom?
|
Cool, thanks @jacobtoye. I'm traveling today so I'll make the changes later this evening or tomorrow. @ryansit - no, the existing auto logic is the same. Not sure what the desired behavior is or how we should set up the API to specify which direction the auto should fallback to, you know? Would love to hear some feedback if you have any strong feelings. |
I'm traveling too. Without diving into the code, right now there is left, right and auto. You added top bottom. Probably need autovertical that works like the other auto. The horiOntal auto seems to work with the middle point being the switch.
|
+1 for this feature |
definitely would be nice to have. |
+1 for this feature! |
This seems like something I could definitely use. I was looking into using Rrose to give me automatic positioning for marker popups, but this may work as well. Basically, I want the popup to determine its own direction that will not cause the map to pan when it pops up. |
For popups I would use Leaflet.Rrose. This pull needs to be updated to get to a stage that it can be merged. |
I'd really like this! 👍 |
Any update about this feature ? |
👍 |
Possible fix for #47 (fyi @ryansit, @astetik).
Wanted to put this up and see what you thought. Some of the CSS could be cleaned up a bit.
What do you think?