-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minified version removes exposed methods. #16864
Comments
The minified version is just 2 months old. You can build minified version of latest code with:
My personal view on this is that adding a minified version with each commit makes it harder to view diffs. @LeaVerou Since minified version wasn't always updated with each commit before anyways, maybe doing it with each release instead would work better for us? Maybe we waited long enough for feedback on new feature #16852. If so, I can get back working on 1.1 release and add minified version among other things when it's ready. |
I think we should run gulp watch every time we work on this, so that the minified version is automatically generated. Having an out of sync minified version is definitely not something we should make a rule about. |
Ah, so there was a version discrepancy... Didn't know! Thanks for clarifying. I kind of expected them to be in sync, so +1 on what @LeaVerou said. |
We can't be sure people will actually run And what about:
Is it time to merge this PR and start work on other tickets for 1.1? |
Obviously, an automated solution is better, but we should try to keep it in sync as much as possible, one way or another. Yes, it is time to merge that change. |
Landed in cleaned up version #16866. |
Version 1.1 just published. Minified version is in sync https://github.com/LeaVerou/awesomplete/releases/tag/v1.1.0 |
The minified version removes
Awesomplete.ITEM
andAwesomplete.REPLACE
.awesomplete.js
awesomplete.min.js
(beautified)...with
Awesomplete.ITEM
andAwesomplete.REPLACE
no longer available. This is how we're usingAwesomplete.ITEM
, which won't work in the minified version:The text was updated successfully, but these errors were encountered: