-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom class #16855
Comments
This seems to be a very special case. If someone wants to add an attribute instead of a class do we create another config option? |
I have to say, I do think there is merit in allowing users to use their own classes, mostly for integrating with an existing design system. #16805 is a long standing PR on this. |
I didn’t say it shouldn’t be allowed, I just said I'd be more interested in a generic way that also allows them to add attributes etc. |
In contrast to a data attribute (or something else) a custom class is, at least in my opinion, a more common case. |
Once we make |
Here's my implementation, using
This allows you to pass a Here's a simple example:
|
Pretty straightforward, giving the option for own classes for the wrapper.
Eq.
Code changes:
First [21-30]
second [34-39]
The text was updated successfully, but these errors were encountered: