Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WrapError to utils #116

Closed
shrimalmadhur opened this issue Feb 14, 2024 · 0 comments · Fixed by #203
Closed

Move WrapError to utils #116

shrimalmadhur opened this issue Feb 14, 2024 · 0 comments · Fixed by #203
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@shrimalmadhur
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

  • Currently WrapError function lives in types which doesn't seem right place
  • Interface expects two errors which is not great since, a lot of places has a string input (and error inputs in some place)

Describe the solution you'd like

  • Move WrapError to utils or similar
  • Interface should accept any type and then based on type do the Wrapping.

Describe alternatives you've considered

Additional context
@shrimalmadhur shrimalmadhur added the enhancement New feature or request label Feb 14, 2024
@shrimalmadhur shrimalmadhur mentioned this issue Feb 14, 2024
Merged
@samlaf samlaf added the good first issue Good for newcomers label Apr 10, 2024
This was referenced Apr 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: wrap error type renlulu/eigensdk-go
refactor: wrap error renlulu/eigensdk-go
2 participants
@shrimalmadhur @samlaf