Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow using int and string on ids #5752

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: allow using int and string on ids #5752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
081a946
fix: allow string id on PHPDoc for ShowOperation
Chemaclass Jan 22, 2025
d537953
fix: allow string id on PHPDoc for UpdateOperation
Chemaclass Jan 22, 2025
8812778
fix: allow string id on PHPDoc for Read trait
Chemaclass Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/Http/Controllers/Operations/ShowOperation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ protected function setupShowDefaults()
/**
* Display the specified resource.
*
* @param int $id
* @param int|string $id
* @return \Illuminate\Contracts\View\View
*/
public function show($id)
Expand Down
2 changes: 1 addition & 1 deletion src/app/Http/Controllers/Operations/UpdateOperation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ protected function setupUpdateDefaults()
/**
* Show the form for editing the specified resource.
*
* @param int $id
* @param int|string $id
* @return \Illuminate\Contracts\View\View
*/
public function edit($id)
Expand Down
4 changes: 2 additions & 2 deletions src/app/Library/CrudPanel/Traits/Read.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public function getCurrentEntryWithLocale()
/**
* Find and retrieve an entry in the database or fail.
*
* @param int The id of the row in the db to fetch.
* @param int|string The id of the row in the db to fetch.
* @return \Illuminate\Database\Eloquent\Model The row in the db.
*/
public function getEntry($id)
Expand Down Expand Up @@ -116,7 +116,7 @@ public function getModelWithCrudPanelQuery()
/**
* Find and retrieve an entry in the database or fail.
*
* @param int The id of the row in the db to fetch.
* @param int|string The id of the row in the db to fetch.
* @return \Illuminate\Database\Eloquent\Model The row in the db.
*/
public function getEntryWithoutFakes($id)
Expand Down
Loading