Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Purple. The New Black. WotG mission 7 progression #6581

Open
3 tasks done
Scarface-x opened this issue Dec 23, 2024 · 0 comments
Open
3 tasks done

🐛 Purple. The New Black. WotG mission 7 progression #6581

Scarface-x opened this issue Dec 23, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Scarface-x
Copy link

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows 11 Pro

Branch affected by issue

base

Steps to reproduce

Enter the BCNM, kill the dragon, when teleported out, no cutscene is played.

Expected behavior

When teleported out, event 6 should play.

Potential fix

The following bit of code on line 47:

onZoneIn = function(player, prevZone)
    if player:getMissionStatus(mission.areaId) == 2 then
        return 6
    end
end,

Doesn't fire because of the conditional check on line 42:

return currentMission == mission.missionId and missionStatus == 1

Changing line 42 to:

return currentMission == mission.missionId and missionStatus >= 1

Allows progression.

@Scarface-x Scarface-x added the bug Something isn't working label Dec 23, 2024
@zach2good zach2good added the good first issue Good for newcomers label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants