Missing "You throw away a [item]." message (plus Windower/Shortcuts issue).

[UynGH]

• I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
• I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated
• I have read and understood the Contributing Guide

Branch affected by issue

base and client updated as of 06/07/22.

Steps to reproduce

I encountered two issues regarding messages lately. I can separate them if needed.

First one: There is no message displayed when you throw away something (might be related to the Recycle Bin).

Related to Shortcuts with Windower exclusively
Second one: When you use a Job Ability or trying to call Trusts while in combat and having hate (these two situations in particular because I tried spells or ranged weapons and it didn't happen) directly from the menu, it acts like you tried to fire it two times in a row:


Note: Work as intended if they are used through direct typed command or macros.

Expected behavior

First one:

Related to Shortcuts with Windower exclusively
Second one: Only one of these messages displayed for Job Abilities or Trusts casting while in combat.

Thank you!

[WinterSolstice8]

The source of this appears to be from addon load order on windower

I can produce it with:
//lua unloadall
//lua load gearswap
//lua load shortcuts
-> use the menu to summon a trust, 0x1A comes twice

//lua unloadall
//lua load shortcuts
//lua load gearswap
-> use the menu to summon a trust, 0x1A comes once

Ashita is affected too, but need more investigation

[WinterSolstice8]

Nevermind, Ashita does not have this bug in my setup.

[WinterSolstice8]

Update:
I tried to make a minimal repro setup on windower to load up retail and then LSB with fixed scripts to demonstrate the issue and it appears retail does not have this problem and I cannot currently explain why. Retail only sends one packet, not two.

[WinterSolstice8]

Windower/Lua#2238 got merged, you'll need to use windower dev or manually merge in the change to Shortcuts to see if the second issue still affects you.

[UynGH]

Thanks for going down the rabbit hole, Winter. Edited the title and message accordingly for the last issue.

[UynGH]

First part fixed by: #3196
Second part fixed by: Windower/Lua#2238
Thank you, Winter!