LibWeb: Use WindowProxy instead of Window in UI Events IDL #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this is an error in the UI Events spec, and it should be updated to match the HTML spec (which uses WindowProxy everywhere). This fixes a bunch of issues already covered by existing WPT tests. Spec bug: w3c/uievents#388 Note that WebKit has been using WindowProxy instead of Window in UI Events IDL since 2018: WebKit/WebKit@816158b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is an error in the UI Events spec, and it should be updated to match the HTML spec (which uses WindowProxy everywhere).
This fixes a bunch of issues already covered by existing WPT tests.
Spec bug: w3c/uievents#388
Note that WebKit has been using WindowProxy instead of Window in UI Events IDL since 2018:
WebKit/WebKit@816158b