Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History not changing well in mobile #23

Open
rockcesar opened this issue Jul 8, 2021 · 3 comments
Open

History not changing well in mobile #23

rockcesar opened this issue Jul 8, 2021 · 3 comments
Assignees
Labels
bug Something isn't working easy for beginners Easy for beginners good first issue Good for newcomers hacktoberfest Good for new contributors - https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed trivial Small tasks or easy tweaks up-for-grabs Good for new contributors - https://up-for-grabs.net/

Comments

@rockcesar
Copy link

rockcesar commented Jul 8, 2021

History not changing well in mobile. When I try to click in history, the history play doesn't appears well in Mobile. In Desktop it's working well. I recomment this.

In file js/board-init.js, line 62, comment loadBoard:

$('#game-turns-history li span').off().click(function() {
var turnN = parseInt($(this).attr('turn'));
console.log('History: show turn ' + $(this).attr('turn'));
moves = JSON.parse(localStorage.getItem('boardHistory'));
console.log(moves[turnN-1]);
//loadBoard(moves[turnN-1], true);
});

@LabinatorSolutions
Copy link
Owner

Hello!

Thank you for your bug report. We have assigned you to fix this bug if you have time. Our team is highly occupied with other projects at the moment.

All the best!

@LabinatorSolutions LabinatorSolutions added bug Something isn't working easy for beginners Easy for beginners good first issue Good for newcomers hacktoberfest Good for new contributors - https://hacktoberfest.digitalocean.com/ up-for-grabs Good for new contributors - https://up-for-grabs.net/ help wanted Extra attention is needed trivial Small tasks or easy tweaks labels Jul 10, 2021
@rockcesar
Copy link
Author

Done with this pull request: #28

@LabinatorSolutions LabinatorSolutions changed the title History not changing well in mobile, I recomment this History not changing well in mobile Mar 14, 2024
@LabinatorSolutions
Copy link
Owner

The whole history viewer require replacing with a modern library. The one that is currently being used is already outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy for beginners Easy for beginners good first issue Good for newcomers hacktoberfest Good for new contributors - https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed trivial Small tasks or easy tweaks up-for-grabs Good for new contributors - https://up-for-grabs.net/
Projects
None yet
Development

No branches or pull requests

2 participants