Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scarlet note LinAlg #495

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Scarlet note LinAlg #495

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6119d5d
note on LinAlg error for Scarlet
ismael-mendoza Apr 26, 2024
c8e594f
issue
ismael-mendoza Apr 26, 2024
7058da7
typo
ismael-mendoza Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions btk/deblend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,13 @@ def __init__(
of the argument also see the Scarlet API at:
https://pmelchior.github.io/scarlet/api/scarlet.initialization.html.

Note that as of commit 45187fd, Scarlet raises a `LinAlg` error if two sources are on
the same pixel, which is allowed by the majority of currently implemented sampling
functions in BTK. To get around this, our Deblender implementation automatically
catches this exception and outputs an array of zeroes for the deblended images of the
particular blend that caused this exception. See this issue for details:
https://github.com/pmelchior/scarlet/issues/282#issuecomment-2074886534

Args:
max_n_sources: See parent class.
thresh: Multiple of the backround RMS used as a flux cutoff for morphology
Expand Down
Loading