Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various issues with unit tests #83

Closed
4 tasks done
ismael-mendoza opened this issue Dec 14, 2020 · 0 comments · Fixed by #93
Closed
4 tasks done

various issues with unit tests #83

ismael-mendoza opened this issue Dec 14, 2020 · 0 comments · Fixed by #93
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ismael-mendoza
Copy link
Collaborator

ismael-mendoza commented Dec 14, 2020

I find that unit tests are very redundant and hard to reproduce, in particular some of them are breaking even though the images and the corresponding code is still the same. It's really hard to figure out why though

In general, I'm not sure if we should include scarlet/sep/lsst in the unit tests. I feel that correctness of the images produced should be independent of the algorithms for detection.

I think the testing suite needs an overhaul in terms of deciding whether each test is should actually be included. Here is a list of things that I'm debating whether we should include in the testing suite at all:

  • whether detection works by various algorithms like sep/scarlet/lsst

  • group sampling functions from WeakLensingDeblending (these seems like an additional feature to define realistic groups, but maybe we should move away from depending on descwl and definite our own groups as suggested in Implement friends-of-friends algorithm to generate blends #16)

  • most of the config tests are broken, these need to be revived at the same time as btk_input is broken and cannot be currently used  #48 (they are more broken now than before because of definite our own Survey objects instead of a string)

  • Tests should not depend on band order which can be easily switched (architecture in general should use dictionaries for bands?)

@ismael-mendoza ismael-mendoza added bug Something isn't working help wanted Extra attention is needed labels Dec 14, 2020
@ismael-mendoza ismael-mendoza self-assigned this Jan 15, 2021
@ismael-mendoza ismael-mendoza mentioned this issue Feb 22, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant