Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rotation to sampling functions #370

Closed
ismael-mendoza opened this issue Sep 16, 2022 · 2 comments
Closed

add rotation to sampling functions #370

ismael-mendoza opened this issue Sep 16, 2022 · 2 comments
Assignees
@b-biswas
Milestone
1.0.0

Comments

@ismael-mendoza
Copy link
Collaborator

  • reduce effect of having exact same object
@ismael-mendoza ismael-mendoza added this to the 1.0.0 milestone Sep 16, 2022
@ismael-mendoza
Copy link
Collaborator Author

@b-biswas since you have worked on this would you like to add it to BTK? @aguinot suggested this might be a good idea

@ismael-mendoza
Copy link
Collaborator Author

Thomas: be careful about where to track the angle, perhaps add a btk_rotation parameter and apply it in the galaxy model level. Sampling function is the most logical place to sample and add it.

@b-biswas b-biswas mentioned this issue Oct 7, 2022
Closed
@ismael-mendoza ismael-mendoza mentioned this issue Oct 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b-biswas b-biswas

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@ismael-mendoza @b-biswas