Added a plugin action for the sync in command. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks! |
LPGhatguy
reviewed
Jun 19, 2018
plugin/src/Main.server.lua
Outdated
| end | ||
|
|
||
| toolbar:CreateButton("Sync In", "Sync into Roblox Studio", Config.icons.syncIn).Click:Connect(syncIn) | ||
| plugin:CreatePluginAction("RojoSyncIn", "Sync In Rojo Project", "Pulls the connected Rojo project into Studio.").Triggered:Connect(syncIn) |
There was a problem hiding this comment.
Looks like this line is too long based on the Luacheck policy we've got, and I'm inclined to agree.
Can we take the strings out and put them into constants? I think the 'Sync In Rojo Project' part should probably be the same between the button and the action.
LPGhatguy
reviewed
Jun 19, 2018
| end | ||
|
|
||
| local dShort = "Sync In" | ||
| local dLong = "Sync into Roblox Studio" |
There was a problem hiding this comment.
Can we spell out these variable names? shortLabel and longLabel would be fine I imagine.
LPGhatguy
added a commit
that referenced
this pull request
Jun 21, 2018
|
I tried to manually merge this locally and messed it up! Rest assured, your code has landed and should be in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79.