Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Js and Css are injected twice on the text. #664

Closed
5 tasks done
Palloxin opened this issue Jun 16, 2023 · 2 comments
Closed
5 tasks done

[Bug] Js and Css are injected twice on the text. #664

Palloxin opened this issue Jun 16, 2023 · 2 comments
Labels
Bug Something isn't working

Comments

@Palloxin
Copy link
Contributor

Palloxin commented Jun 16, 2023

Steps to reproduce

  1. Take a freshly installed version of lnreader 1.1.19
  2. AllNovelFull, Hidden marriage, add to the library
  3. Download chapter 1 and 2
  4. Inject this JS:
alert(chapterName)
  1. Open chapter 1, scroll until the bottom and click "Next chapter" (see video below).

Expected behavior

  • Js and css applied only once so the alert should popup only once.

Actual behavior

Js applied twice when the chapters in question are downloaded.

YouCut_20240609_155048374.mp4

LNReader version

1.1.18 and 1.1.19(the bug exists since the first time i started using lnreader so.. 1.1.15.1, idk previous versions)

Android version

Android 8 Miui 8

Device

huawei p8 lite 2017

Other details

This issue has been almost completely rewritten on 4th November 2023
It is a re-opened issue because devs couldn't reproduce it even with the video so i think one needs to guess the cause of it correctly to fix it or test it on android 8.

EDIT: another re-edit in 9th of June 2024

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with a source, I should be opening an issue in the sources repository.
  • I have updated the app to version 1.1.15.
  • I will fill out all of the requested information in this form.
@Palloxin Palloxin added the Bug Something isn't working label Jun 16, 2023
@Palloxin Palloxin closed this as completed Jul 2, 2023
@Palloxin Palloxin reopened this Jul 2, 2023
@rajarsheechatterjee
Copy link
Member

Not able to reproduce this with simpler scripts.

Your custom JS might be replacing / setting the HTML content more than once which could probably cause this.

@rajarsheechatterjee rajarsheechatterjee closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2023
@LNReader LNReader unlocked this conversation Nov 4, 2023
@Palloxin Palloxin changed the title [Aesthetic Flaw] Js is injected twice on the text. [Aesthetic Flaw] Js and Css are injected twice on the text. Jan 8, 2024
@Palloxin
Copy link
Contributor Author

Palloxin commented Jan 16, 2024

YouCut_20240116_155930606.mp4

Here you can see that the JS has been applied already when the chapter loaded, then It lagged a bit, the chapter resetted and the JS applied again before the chapter_progress_resume feature activated. You can see it by the string 0.5 becoming 0.1999999284.

@Palloxin Palloxin changed the title [Aesthetic Flaw] Js and Css are injected twice on the text. [Bug] Js and Css are injected twice on the text. Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants