Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The download process is not visible and the notification is not displayed correctly #1383

Open
5 tasks done
VectorNEON opened this issue Jan 2, 2025 · 7 comments · May be fixed by #1384
Open
5 tasks done

The download process is not visible and the notification is not displayed correctly #1383

VectorNEON opened this issue Jan 2, 2025 · 7 comments · May be fixed by #1384
Labels
Bug Something isn't working

Comments

@VectorNEON
Copy link

Steps to reproduce

cats
After updating to Github Action 2.0.0 (01/01/25 11:58 AM UTC) Commit: 9636aab two problems appeared

  1. the process of downloading chapters is not visible, while the download is in progress (screen 2).
  2. the notification does not work correctly, when chapters are downloading, the notification says “Preparation” throughout the entire time the chapters are downloading.

Expected behavior

  1. it should be visible that the chapter is in the process of loading or is waiting for its turn to be loaded
  2. Instead of “Preparation,” the name of the currently loading chapter should be written.

Actual behavior

  1. the process of downloading or preparing for downloading is not visible
  2. you can’t see which chapter is loading.

LNReader version

Github Action 2.0.0 (01/01/25 11:58 AM UTC) Commit: 9636aab

Android version

Android 10

Device

Realme C11 (2020)

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with a source, I should be opening an issue in the sources repository.
  • I have updated the app to version 2.0.0.
  • I will fill out all of the requested information in this form.
@VectorNEON VectorNEON added the Bug Something isn't working label Jan 2, 2025
@Soopyboo32
Copy link
Contributor

will investigate

@Soopyboo32
Copy link
Contributor

Soopyboo32 commented Jan 2, 2025 •
edited
Loading

the process of downloading chapters is not visible, while the download is in progress (screen 2).

This issnt a bug afaik cus there is no (easy) way to know the progress
cus 99% of the time is spend waiting on the server to send us the chapter

(unless in prior versions it showed more info?)

@VectorNEON
Copy link
Author

the process of downloading chapters is not visible, while the download is in progress (screen 2).

This issnt a bug afaik cus there is no (easy) way to know the progress cus 99% of the time is spend waiting on the server to send us the chapter

(unless in prior versions it showed more info?)

Error, here is a screenshot from beta 3
It doesn't have these two problems.

  1. it is clear that the chapters are in the process of loading
  2. the title of the chapter is also visible in the notification
    cats

@Soopyboo32
Copy link
Contributor

oh you mean in that page i see

@Soopyboo32
Copy link
Contributor

managed to fix the issue with the loading spinners not showing, am working on the notification now

@Soopyboo32
Copy link
Contributor

Figured it out, pr soon

@VectorNEON
Copy link
Author

oh you mean in that page i see

I showed the "Task Queue" section to show that the chapters are loading, but this is not displayed in the program itself, although the circle should spin like in beta 3
I think you understand what I mean, I’m not always a master of explanations

@Soopyboo32 Soopyboo32 linked a pull request Jan 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some bugs with task queue Soopyboo32/lnreader
2 participants
@Soopyboo32 @VectorNEON