Better bottom navigation #1335
Better bottom navigation #1335
Conversation
|
0-0 wait today i learn u can double press on the browse button in mihon to open global search, will add that aswell |
|
more page opens settings & history page opens next chapter of last read novel |
|
also just cherry-picked the same lint error fix so it stops complaining :madge: |
src/navigators/BottomNavigator.tsx
Outdated
| const pluginsWithUpdate = filteredInstalledPlugins.filter( | ||
| p => p.hasUpdate, | ||
| ).length; |
There was a problem hiding this comment.
should use useMemo to avoid unnessary calculations
There was a problem hiding this comment.
dont think we can here cus it has to update when they update a plugin
There was a problem hiding this comment.
useMemo has dependencies option,
const pluginsWithUpdate = useMemo(() => filteredInstalledPlugins.filter(
p => p.hasUpdate,
).length;, [filteredInstalledPlugins]);There was a problem hiding this comment.
i guess its fine cus when u update a plugin it creates a new plugin object instead of modifying existing, when u refresh the plugin indicator it just mutates existing objects tho so memo wont be rerun
tbh users arent likely to manually reload plugins tho so ig fine
All changes match mihon functionality