Small changes following faster global search pr #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soopyboo32
commented
Nov 14, 2024
| @@ -163,7 +163,7 @@ const initialAppSettings: AppSettings = { | |||
| const initialBrowseSettings: BrowseSettings = { | |||
| showMyAnimeList: true, | |||
| showAniList: true, | |||
| globalSearchConcurrency: 1, | |||
| globalSearchConcurrency: 3, | |||
There was a problem hiding this comment.
most phones should be able to handle 3 and the first few concurrency increases makes a massive difference in loading time so may as well increase default
Soopyboo32
commented
Nov 14, 2024
| import { useAppSettings } from '@hooks/persisted'; | ||
| import { interpolateColor } from 'react-native-reanimated'; | ||
|
|
||
| const useLoadingColors = (theme: ThemeColors) => { |
There was a problem hiding this comment.
renamed to use cus of the useAppSettings inside
Soopyboo32
commented
Nov 14, 2024
| @@ -68,7 +68,7 @@ const NovelInformation = memo(() => ( | |||
| </View> | |||
| )); | |||
|
|
|||
| const ChapterItem = memo(({ index }: { index: number }) => ( | |||
| const ChapterItem = memo(() => ( | |||
There was a problem hiding this comment.
lint was mad at unused variable so i removed it
There was a problem hiding this comment.
maybe lint gives problems because Traitor latest commit bypassed lint verification.
nyagami
approved these changes
Nov 17, 2024
|
I dont think it's good looking, why blue? YouCut_20241120_230513570.mp4Even here it seems out of place. |
its just a blend of the existing colors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the colour looks like for loading stuff:
