Saving Instrument does not Save midi configuration

[Lysil620]

System Information

Windows 11

LMMS Version(s)

lmms-1.3.0-alpha.1.738+g23db892d5-mingw-win64

Most Recent Working Version

No response

Bug Summary

When i save an instrument as a .xpf and then load it the information in the "MIDI" tab does is not correct. It is always the default value instead of the value that was present when the .xpf was made.

Expected Behaviour

The values in the "MIDI" tab of an instrument loaded from a .xpf should the the same as they are in the instrument the .xpf was made from.

Steps To Reproduce

Open an instrument.
Go to the "MIDI" tab.
Change one of the values (Example: change fixed note velocity to 100).
Click on the save button.
Save the instrument as a .xpf.
Load the instrument into the project.
Open the new instrument and check the "MIDI" tab.

Logs

Click to expand

Screenshots / Minimum Reproducible Project

No response

Please search the issue tracker for existing bug reports before submitting your own.

• I have searched all existing issues and confirmed that this is not a duplicate.

[michaelgregorius]

Storing the MIDI information in presets was explicitly removed via PR #7445 as a fix for #3922 which requested to not save the MIDI information to presets.

IMO not saving the MIDI information to presets is the correct behavior. An instrument preset should store information about how an instrument sounds but not some MIDI routing that will very likely differ from user to user anyway. Put differently: describing the sound of an instrument and making that instrument sound are two very distinctive things.

In many DAWs MIDI routing information is part of the track anyway and not of an instrument.