Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image files detection does not work properly #128

Closed
LMH01 opened this issue Mar 8, 2023 · 1 comment
Closed

Image files detection does not work properly #128

LMH01 opened this issue Mar 8, 2023 · 1 comment
Labels
accepted This request has been accepted and will be worked on bug Something isn't working pending release The issue/feature has been fixed/added and is being implemented in the next release

Comments

@LMH01
Copy link
Owner

LMH01 commented Mar 8, 2023

Describe the bug
See #127 :

I just tested it and I can't quite replicate the problem:

Everything works flawlessly when I do the following:

1. Create new Initial backup
2. Start Mod-Tool and import the extracted .zip file
3. Check box that allows modification of already existing content
4. Import works without problems
5. Check if the png files are missing, they are still there

Oddly what did not work properly was importing the .zip file. When I imported the .zip file (so that the tool needed to extract the files) some problems occurred, mainly that some image files are missing. So it seems like something either with the .zip file is broken or that the extraction method is broken somehow. This will have to be tested separately. I will create a new issue for that.

Edit: Maybe this is also somehow related to the operating system. I performed my tests under Linux.

To Reproduce
Steps to reproduce the behavior:
Do the same as above accept that the .zip file is selected.

Expected behavior
The image files should not be missing

Screenshots

Desktop (please complete the following information):

  • OS: Linux, Windows
  • Version v4.9.0-beta4

Additional context

@LMH01 LMH01 added bug Something isn't working help wanted Extra attention is needed accepted This request has been accepted and will be worked on labels Mar 8, 2023
@LMH01 LMH01 changed the title Extraction of .zip files does not work reliabily Image files detection does not work properly Mar 8, 2023
@LMH01
Copy link
Owner Author

LMH01 commented Mar 8, 2023

The zip file extraction was not the problem, the problem was a false heuristic for the detection of platform image files.

@LMH01 LMH01 added pending release The issue/feature has been fixed/added and is being implemented in the next release and removed help wanted Extra attention is needed labels Mar 8, 2023
@LMH01 LMH01 closed this as completed in 0b18569 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This request has been accepted and will be worked on bug Something isn't working pending release The issue/feature has been fixed/added and is being implemented in the next release
Projects
None yet
Development

No branches or pull requests

1 participant