Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add small comments in Mac TPL build documentation #1187

Merged
merged 7 commits into from
Aug 1, 2024

Conversation

chapman39
Copy link
Contributor

I'm going through the Mac build documentation for my machine. So far I just added one comment.

I was getting thrown off by the documentation mentioning /opt/homebrew for the installation prefix, when it's /usr/local for Intel-based Macs. I'm new to using brew, so maybe I'm just a noob, but it did take me a bit to figure out.

@chapman39 chapman39 added documentation Improvements or additions to documentation WIP Work in progress labels Jul 30, 2024
@chapman39 chapman39 self-assigned this Jul 30, 2024
@btalamini
Copy link
Collaborator

I think there is a command to query homebrew's prefix. Googling turns up brew --prefix. I don't have homebrew, so I can't check - can one of you brew users try? This could make the instructions more generic, as well as handle the case that a user installed homebrew in a non-default location

@chapman39 chapman39 changed the title WIP: Add small comment in mac documentation WIP: Add small comments in Mac TPL build documentation Jul 30, 2024
@chapman39
Copy link
Contributor Author

@btalamini I added a comment about brew --prefix, thanks.

Rather referring to the assumed prefix /opt/homebrew, do we want something generic like ${BREW_PREFIX} in the documentation? I don't have a strong preference either way.

@chapman39
Copy link
Contributor Author

I'm very confused why this is happening when I have +devtools. Has +devtools been tested on macos?

[exe: /Users/chapman39/dev/serac/serac_libs1/spack/bin/spack -D /Users/chapman39/dev/serac/serac_libs1/spack_env concretize --fresh ]
==> Error: concretization failed for the following reasons:

   1. Cannot select a single "version" for package "py-numpy"
[spack version: 0.22.0.dev0 (6d244b3f6776b3697861c6b5cebbee376c30bff3)
]

Only when I remove the python section from my spack.yaml, I'm able to concretize with +devtools.

@tupek2 tupek2 self-requested a review July 30, 2024 20:25
@chapman39
Copy link
Contributor Author

Looks like boundary condition boundary_cond test fails. I can look into this a bit more but wanted to report.

***********************************
[WARNING in line 67 of file /Users/chapman39/dev/serac/repo/src/serac/infrastructure/../../serac/physics/boundary_conditions/boundary_condition.hpp]
MESSAGE=Attempting to compare tags of two different enum types (always false)
***********************************

...

[  FAILED  ] 1 test, listed below:
[  FAILED  ] BoundaryCond.DirectTrueDofs

@@ -291,6 +291,8 @@ If you plan to install the developer tools, you should also run
$ ln -s /opt/homebrew/opt/llvm@14/bin/clang-format /opt/homebrew/bin/clang-format

If you have installed Homebrew using the default installation prefix, most packages will be accessible through the prefix ``/opt/homebrew``.
Note for Intel-based Macs, the installation prefix is ``/usr/local``. If you set a custom prefix or aren't sure what the prefix is, run ``brew --prefix``.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chapman39, since you asked, my preference would be to replace /opt/homebrew everywhere in this section with $(brew --prefix) since that will always do the right thing. But we can do that later. Let's just get this in.

@tupek2 tupek2 merged commit d0d8d7e into develop Aug 1, 2024
2 checks passed
@chapman39 chapman39 deleted the task/chapman39/small-mac-docs-tweaks branch August 9, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants