diff --git a/src/serac/infrastructure/accelerator.hpp b/src/serac/infrastructure/accelerator.hpp index 9c7601400..3d7c884c0 100644 --- a/src/serac/infrastructure/accelerator.hpp +++ b/src/serac/infrastructure/accelerator.hpp @@ -165,7 +165,7 @@ void zero_out(axom::Array& arr) #ifdef __CUDACC__ /// @overload template -void zero_out(axom::Array>& arr) +void zero_out(axom::Array& arr) { cudaMemset(arr.data(), 0, static_cast(arr.size()) * sizeof(T)); } diff --git a/src/serac/numerics/functional/finite_element.hpp b/src/serac/numerics/functional/finite_element.hpp index 86b5355e2..35a29418e 100644 --- a/src/serac/numerics/functional/finite_element.hpp +++ b/src/serac/numerics/functional/finite_element.hpp @@ -362,7 +362,7 @@ SERAC_HOST_DEVICE void physical_to_parent(tensor& qf_output, const tensor< * }; * */ -template +template struct finite_element; #include "detail/segment_H1.inl" diff --git a/src/serac/numerics/functional/functional_qoi.inl b/src/serac/numerics/functional/functional_qoi.inl index 801426c49..a54ec394f 100644 --- a/src/serac/numerics/functional/functional_qoi.inl +++ b/src/serac/numerics/functional/functional_qoi.inl @@ -428,8 +428,7 @@ private: gradient_L_ = 0.0; - std::map> - element_gradients[Domain::num_types]; + std::map> element_gradients[Domain::num_types]; for (auto& integral : form_.integrals_) { auto& K_elem = element_gradients[integral.domain_.type_]; @@ -437,8 +436,8 @@ private: if (K_elem.empty()) { for (auto& [geom, trial_restriction] : trial_restrictions) { - K_elem[geom] = ExecArray( - trial_restriction.num_elements, 1, trial_restriction.nodes_per_elem * trial_restriction.components); + K_elem[geom] = ExecArray(trial_restriction.num_elements, 1, + trial_restriction.nodes_per_elem * trial_restriction.components); detail::zero_out(K_elem[geom]); } diff --git a/src/serac/numerics/functional/integral.hpp b/src/serac/numerics/functional/integral.hpp index f3b29e8b8..3c9216211 100644 --- a/src/serac/numerics/functional/integral.hpp +++ b/src/serac/numerics/functional/integral.hpp @@ -280,7 +280,7 @@ Integral MakeDomainIntegral(const Domain& domain, const lambda_type& qf, SLIC_ERROR_IF(domain.type_ != Domain::Type::Elements, "Error: trying to evaluate a domain integral over a boundary"); - Integral integral(std::move(domain), argument_indices); + Integral integral(domain, argument_indices); if constexpr (dim == 2) { generate_kernels(signature, integral, qf, qdata); @@ -379,7 +379,7 @@ Integral MakeBoundaryIntegral(const Domain& domain, const lambda_type& qf, std:: SLIC_ERROR_IF(domain.type_ != Domain::Type::BoundaryElements, "Error: trying to evaluate a boundary integral over a non-boundary domain of integration"); - Integral integral(std::move(domain), argument_indices); + Integral integral(domain, argument_indices); if constexpr (dim == 1) { generate_bdr_kernels(signature, integral, qf); diff --git a/src/serac/numerics/functional/shape_aware_functional.hpp b/src/serac/numerics/functional/shape_aware_functional.hpp index d9ae8fdcd..fe16b7d3d 100644 --- a/src/serac/numerics/functional/shape_aware_functional.hpp +++ b/src/serac/numerics/functional/shape_aware_functional.hpp @@ -459,12 +459,11 @@ class ShapeAwareFunctional { { if constexpr (std::is_same_v) { functional_->AddDomainIntegral(Dimension{}, DependsOn<0, (args + 1)...>{}, - std::move(ShapeAwareIntegrandWrapper(integrand)), domain, - qdata); + ShapeAwareIntegrandWrapper(integrand), domain, qdata); } else { functional_->AddDomainIntegral(Dimension{}, DependsOn<0, (args + 1)...>{}, - std::move(ShapeAwareIntegrandWrapperWithState(integrand)), - domain, qdata); + ShapeAwareIntegrandWrapperWithState(integrand), domain, + qdata); } } @@ -517,8 +516,7 @@ class ShapeAwareFunctional { void AddBoundaryIntegral(Dimension, DependsOn, const lambda& integrand, domain_type& domain) { functional_->AddBoundaryIntegral(Dimension{}, DependsOn<0, (args + 1)...>{}, - std::move(ShapeAwareBoundaryIntegrandWrapper(integrand)), - domain); + ShapeAwareBoundaryIntegrandWrapper(integrand), domain); } /** diff --git a/src/serac/physics/heat_transfer.hpp b/src/serac/physics/heat_transfer.hpp index 7662dce2f..0147658bd 100644 --- a/src/serac/physics/heat_transfer.hpp +++ b/src/serac/physics/heat_transfer.hpp @@ -439,7 +439,7 @@ class HeatTransfer, std::integer_sequ template void setMaterial(const MaterialType& material) { - setMaterial(DependsOn<>{}, std::move(material)); + setMaterial(DependsOn<>{}, material); } /** diff --git a/src/serac/physics/thermomechanics.hpp b/src/serac/physics/thermomechanics.hpp index cf2bc578d..f5d5031e8 100644 --- a/src/serac/physics/thermomechanics.hpp +++ b/src/serac/physics/thermomechanics.hpp @@ -390,7 +390,7 @@ class Thermomechanics : public BasePhysics { template void setMaterial(const MaterialType& material, std::shared_ptr> qdata = EmptyQData) { - setMaterial(DependsOn<>{}, std::move(material), qdata); + setMaterial(DependsOn<>{}, material, qdata); } /**