Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to new version of Stackable or deprecate plugin #418

Closed
cjyabraham opened this issue Jan 16, 2020 · 6 comments
Closed

Upgrade to new version of Stackable or deprecate plugin #418

cjyabraham opened this issue Jan 16, 2020 · 6 comments
Assignees

Comments

@cjyabraham
Copy link
Collaborator

cjyabraham commented Jan 16, 2020

Version 2 is out. Test first to see if it breaks any blocks and layouts. It contains responsive image loading.

@cjyabraham cjyabraham self-assigned this Jan 16, 2020
@cjyabraham cjyabraham reopened this Jan 17, 2020
@cjyabraham
Copy link
Collaborator Author

cjyabraham commented Jan 18, 2020

Some experimenting with this did not go well. We will need to deploy this following these steps:

  1. Install on branch; activate plugin
  2. Go through much of the site content and save each page to put each block on v2; identify broken layouts; some already identified:
  • section-headers don't reach the edge of the screen
  • feature grid boxes here get left-justified against edge of browser and then, when re-saved, the images go narrow
  • text inside of a container changes from white to black on kubecon
  1. Update theme css to account for different stackable styling that breaks site
  2. Deploy and re-save every Event page to put each block on v2; Identify and fix any lingering design issues
  3. Turn off deprecated css/js that stackable v2 initially installs with. (Stackable v2 runs with 2 extra css/js files for deprecated styling. By re-saving every Event on the site, I suspect this will put us on all the v2 versions of the blocks so we don't need to carry these extra files going forward. This needs testing)

This is a huge task and will need @andycochran and I working in parallel to accomplish this. I suspect it will take maybe 2 full days of @andycochran and I working together on this to do the upgrade.

We should assess the importance of doing this and staying up-to-date with stackable. More info on v2 is here. On the one hand, in the future with changing browser technology, staying on the latest version of stackable could be important, now that we've committed to it with our content. It may also be clearer in the future, as v2 matures, that there are new features we really want and will end up justifying this upgrade. For example, apparently v2 has responsive image loading for different device types.

Alternatively, we may decide to phase out Stackable blocks as the native Gutenberg blocks mature and make Stackable no longer needed for what we are doing. In which case, we'd just need to keep the existing version around for old Events but there'll be no need to upgrade. It might be good to try setting up an Event using only Gutenberg blocks and seeing if we can get them to work @meganelizabethphillips? I would also like to assess the increase in weight of the js/css files for v2 and whether these are really moving us forward technologically or just weighing us down with features we don't need. To be continued...

@cjyabraham
Copy link
Collaborator Author

Here's a fake kubecon page using a Gutenberg Cover block instead of a Stackable Container

@cjyabraham
Copy link
Collaborator Author

Old version of stackable css/js: 182KB
New version of stackable with deprecated css/js: 364KB
New version of stackable without deprecated css/js: 178KB

@cjyabraham
Copy link
Collaborator Author

I spoke with @andycochran today and he agrees that we should be moving off of stackable now that Gutenberg blocks have matured. @meganelizabethphillips, let's discuss next time we talk.

@cjyabraham
Copy link
Collaborator Author

Here's a quick summary of how Stackable blocks are currently used on the site:

  • Hero Container block; easily replaced with a Cover block. Example.
  • Section Header; can be replaced with a Cover block but can’t configure gradient; could we use just a solid color for this? Group header also works. Examples. Gutenberg issue tracking custom gradients. We could either wait for Gutenberg to implement configurable gradients or find a way to override the colors with a class applied to the block.
  • Schedule-at-a-glance Container block; can be replaced by Cover or Group but can’t currently configure gradient.
  • Feature grid on China site
  • Image box on this page and here and here and here

@cjyabraham cjyabraham changed the title Upgrade to new version of Stackable Upgrade to new version of Stackable or deprecate plugin Jan 21, 2020
@cjyabraham cjyabraham changed the title Upgrade to new version of Stackable or deprecate plugin Build pages with Gutenberg blocks and deprecate Stackable Jan 23, 2020
@cjyabraham cjyabraham changed the title Build pages with Gutenberg blocks and deprecate Stackable Upgrade to new version of Stackable or deprecate plugin Jan 23, 2020
@cjyabraham
Copy link
Collaborator Author

Closing in favor of #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant