Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Deployment.enc_is_on flag to optionally disable encryption for a test deployment #2

Open
mr-z-ro opened this issue Feb 11, 2017 · 1 comment
Assignees

Comments

@mr-z-ro
Copy link
Member

mr-z-ro commented Feb 11, 2017

Suggested Plan: Optionally disable encryption based on new Deployment.enc_is_on flag

  • Current State: All encryption happens at interfaces to LDLN from the public world (exhaustive list: mobile apps, web app, rest api). Web socket logic does not deal with encryption itself, and decryption already has a de facto flag in “dek” for when it should be invoked (explained below)

    • All locations where the string “Encrypt(“ exists in our codebase are listed here
    • All locations where the string “Decrypt(“ exists in our codebase are listed here
    • Note: should leave the logic in those two functions themselves alone, since they’ll still be used for User creation/auth.
  • Places that should be updated depending on a flag:

    • Mobile Apps (covered in separate sections)
    • Relevant “Decrypt()” calls:
      • Here in web-app syncable_objects controller; this is only a check to ensure a previous encryption call worked; should be updated to be called only when that previous encrypt call is invoked (see below)
      • Here in websocket-server response to diff request, only if “dek” is included as part of request; no change needed in this code itself, but need to update clients to not send dek (which is only being done here by the web app at the moment) and logic will send the raw db contents
    • Relevant “Encrypt()” calls:
      • Here in web-app syncable_objects controller; this is an interface to the LDLN platform, and should be set up based on a org-level config flag
      • Here in rest-api app controller; this is an interface to the LDLN platform, and should be set up based on a org-level config flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant