Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging/distribution issues #42

Closed
clintonb opened this issue Jun 30, 2023 · 3 comments · Fixed by #48
Closed

Fix packaging/distribution issues #42

clintonb opened this issue Jun 30, 2023 · 3 comments · Fixed by #48
Assignees

Comments

@clintonb
Copy link
Contributor

The postinstall script is being run after the package is installed. This works with yarn, but fails for pnpm. I would expect the compiled dist directory to be included in the download from NPM, not to require compilation post-download.

Consider the following:

  1. Include dist in the package uploaded to NPM.
  2. Remove the postinstall script.
@clintonb
Copy link
Contributor Author

@KurtzL thoughts on this? I'm not too familiar with npm packaging, but this is once again an issue. We don't ship tsc in production because we expect packages to have compile their own output.

@KurtzL KurtzL self-assigned this Aug 22, 2023
@KurtzL
Copy link
Owner

KurtzL commented Aug 22, 2023

Hello @clintonb , ok I see, the postinstall script will be remove. Also, I can add the .npmignore to clean unnecessary files. Thanks

@KurtzL KurtzL linked a pull request Aug 22, 2023 that will close this issue
@clintonb
Copy link
Contributor Author

@KurtzL that was my own misunderstanding. The postinstall script was the source of the problem. Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants