Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PagePartBundle] Container parameter in PagePartAdmin can be null #3431

Open
dannyvw opened this issue Aug 19, 2024 · 1 comment
Open

[PagePartBundle] Container parameter in PagePartAdmin can be null #3431

dannyvw opened this issue Aug 19, 2024 · 1 comment

Comments

@dannyvw
Copy link
Contributor

dannyvw commented Aug 19, 2024

The container parameter in the constructor can be null and then this line will trigger an error https://github.com/Kunstmaan/KunstmaanBundlesCMS/blob/7.x/src/Kunstmaan/PagePartBundle/PagePartAdmin/PagePartAdmin.php#L270

Maybe we can remove the container and inject only the event dispatcher?

@acrobat
Copy link
Member

acrobat commented Nov 11, 2024

Yes it's a good idea to inject the correct service but the container property is protected so we need to add a bc layer so this property can be removed in 8.0 and we can already inject the new dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants