Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve on InMemoryStorage proposals #70

Closed
3 of 5 tasks
alexsnaps opened this issue May 26, 2022 · 0 comments
Closed
3 of 5 tasks

Improve on InMemoryStorage proposals #70

alexsnaps opened this issue May 26, 2022 · 0 comments
Assignees
Labels
area/library kind/enhancement New feature or request kind/epic participation/help needed Extra attention is needed status/discussing Further information is requested target/later

Comments

@alexsnaps
Copy link
Member

alexsnaps commented May 26, 2022

Adding this as a dumping ground for ideas of possible improvements we could implement to make InMemoryStorage more memory efficient and made more parallel:

  • Have Counters sharable across threads #69
  • "variadic" counters with interior mutability? (so to only grow the Set under write lock)
  • Get rid of the TtlCache<Counter, i64> and store counters in something like NonBlockingCounter (see InMemoryStore grows unbounded #71)
  • Possibly avoid duplication of data (e.g. Counter.limit, have Limit being composed of Counters instead)… i.e. remodel things to match the reality of the domain, not the persistence of it. Possibly relates to Redefine authority of Limits #74
  • Should we make this a hierarchical storage? One where counters would always sit in memory, certainly for short-lived counters (seconds/minutes, possibly configurable) where persistence make little sense
@alexsnaps alexsnaps added kind/enhancement New feature or request participation/help needed Extra attention is needed status/discussing Further information is requested labels May 26, 2022
@alexsnaps alexsnaps added this to the Limitador v0.4 milestone Jun 17, 2022
@alexsnaps alexsnaps removed this from the Limitador v0.5 milestone Nov 13, 2023
@alexsnaps alexsnaps moved this to In Progress in Kuadrant Dec 8, 2023
@alexsnaps alexsnaps added this to the Limitador v0.6.0 milestone Dec 18, 2023
@alexsnaps alexsnaps moved this from In Progress to Todo in Kuadrant Mar 11, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Kuadrant Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library kind/enhancement New feature or request kind/epic participation/help needed Extra attention is needed status/discussing Further information is requested target/later
Projects
Status: Done
Status: No status
Development

No branches or pull requests

2 participants