Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Move all i64 to u64 #325

Closed
alexsnaps opened this issue May 15, 2024 · 1 comment
Closed

[cleanup] Move all i64 to u64 #325

alexsnaps opened this issue May 15, 2024 · 1 comment

Comments

@alexsnaps
Copy link
Member

I think many i64 that are used come from the fact that Redis doesn't have unsigned integers.
Straight from the gRPC interface, we cast to signed… We should keep things as appropriate and keep things unsigned, and merely cast in the Redis layer.

@alexsnaps
Copy link
Member Author

Fixed in #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant