Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow: github.com/mikefarah/yq/v4@latest requires go1.20 #88

Closed
KevFan opened this issue Aug 11, 2023 · 0 comments · Fixed by #89
Closed

workflow: github.com/mikefarah/yq/v4@latest requires go1.20 #88

KevFan opened this issue Aug 11, 2023 · 0 comments · Fixed by #89
Labels
kind/bug Something isn't working participation/good first issue Good for newcomers size/small target/current

Comments

@KevFan
Copy link
Contributor

KevFan commented Aug 11, 2023 •
edited
Loading

Build bundle workflow is failing due the the latest yq version requires go1.20

go: downloading golang.org/x/xerrors v0.0.0-20220609144429-65e65417b02f
# github.com/mikefarah/yq/v4/pkg/yqlib
Error: /home/runner/go/pkg/mod/github.com/mikefarah/yq/[email protected]/pkg/yqlib/encoder_lua.go:139:[29](https://github.com/Kuadrant/limitador-operator/actions/runs/5831295861/job/15815415261#step:4:30): undefined: strings.CutPrefix
Error: /home/runner/go/pkg/mod/github.com/mikefarah/yq/[email protected]/pkg/yqlib/encoder_lua.go:237:29: undefined: strings.CutPrefix
note: module requires Go 1.20
make: *** [Makefile:131: /home/runner/work/limitador-operator/limitador-operator/bin/yq] Error 1
Error: Process completed with exit code 2.

Instead of the always using the latest version, we should pin in to the last supporting version of go1.19 (v4.34.2 was last working before this issue occurred) or alternatively we can upgrade to go1.20

limitador-operator/Makefile

Line 131 in 5381563

$(call go-install-tool,$(YQ),github.com/mikefarah/yq/v4@latest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working participation/good first issue Good for newcomers size/small target/current
Projects
No open projects
Kuadrant Service Protection
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workflow: pin yq version to v4.34.2 KevFan/limitador-operator
1 participant
@KevFan