Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plan to expose unresolvable conflicts #85

Closed
mikenairn opened this issue Apr 19, 2024 · 0 comments
Closed

Update plan to expose unresolvable conflicts #85

mikenairn opened this issue Apr 19, 2024 · 0 comments
Assignees

Comments

@mikenairn
Copy link
Member

What

Update the logic in the plan to include a way to expose the changes we are ignoring due to conflicts that we can't resolve. e.g Record type changing (CNAME -> A).

Why

The plan will currently in a few places detect that it can't do anything and just ignore the change and do nothing. This is the behaviour we want in these situations, but it also doesn't tell you that it did this, so could lead to confusion if you are expecting a record to be a certain way but it isn't.

How

Add a new field to the plan to contain changes that we can't resolve and check that in the dns record controller before applying changes. Conflict errors should be reported back in the status of the DNSRecord.

Requires:

@mikenairn mikenairn moved this to Ready For Review in Kuadrant Apr 19, 2024
@mikenairn mikenairn self-assigned this Apr 19, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Kuadrant Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants