Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Toolkit Nightly Alpha - KryptonHeaderGroup doesn't disappear #1478

Closed
JeanPasquini opened this issue May 22, 2024 · 17 comments
Closed
Labels
bug Something isn't working fixed This issue has been fixed.
Milestone

Comments

@JeanPasquini
Copy link

Describe the bug

Error message when I try to delete the KryptonHeaderGroup. After to try delete, the component doesn't disapper in the form, so I need to open again the Visual Studio.

Screenshots:
image
image
image


To Reproduce

  1. Put the KryptonHeaderGroup in form
  2. Try exclude the component
  3. Error message

Expected behavior

Delete the component without leaving Visual Studio.


Desktop:

  • Visual Studio (17.9.7)
  • OS: Windows 11 (V23H2)
  • Framework/.NET Version: 4.8
  • Toolkit Nightly Version: 90.24.5.141-alpha
@JeanPasquini JeanPasquini added the bug Something isn't working label May 22, 2024
@giduac
Copy link
Contributor

giduac commented May 22, 2024

@JeanPasquini

I'm having a look into this. It's the result of ongoing work.
It can take a bit before a change is merged.

@giduac
Copy link
Contributor

giduac commented May 22, 2024

Hi @JeanPasquini,

I got it fixed so far and will do some more testing tomorrow.
Probably will be in next week's Nightly build.
I'll let you know here when the PR goes in.

@giduac
Copy link
Contributor

giduac commented May 23, 2024

@Wagnerp
Please assign to me.
TY!

@PWagner1 PWagner1 added the under investigation This bug/issue is currently under investigation. label May 23, 2024
@PWagner1 PWagner1 added this to the Version 90 milestone May 23, 2024
@PWagner1
Copy link
Contributor

@Wagnerp Please assign to me. TY!

@giduac

Now assigned to you

@JeanPasquini
Copy link
Author

JeanPasquini commented May 23, 2024

Is this 'Nightly' version available to contribute?

I found 1 error when I'll put a component (KryptonListView)

image

Would u like to put a new issue or can I describe here and edit the title?

@giduac
Copy link
Contributor

giduac commented May 23, 2024

Hi @Wagnerp,

The KListview class uses the KTreeviewDesigner, this KTreeviewDesigner has it's own action list which does not seem compatible with KListview. I tried an older stable release (80.23.11.321) and there the action list doesn't show in the designer as well.

The Class header as it is now:

    [ToolboxItem(true)]
    [ToolboxBitmap(typeof(ListView))]
    [DefaultEvent("AfterSelect")]
    [DefaultProperty("Nodes")]
    [Designer(typeof(KryptonTreeViewDesigner))]
    [DesignerCategory(@"code")]
    [Description(@"A Kryptonised listview. Does not support the `List or Details View` types")]
    public class KryptonListView : ListView

So the KListview action list works when the Designer is changed to:

    [Designer(typeof(KryptonListViewDesigner))]

I looked back in the history and it has been set to the KTreeviewDesigner ever since.

I there a reason for this or is it a mistake?

@PWagner1
Copy link
Contributor

Hi @Wagnerp,

The KListview class uses the KTreeviewDesigner, this KTreeviewDesigner has it's own action list which does not seem compatible with KListview. I tried an older stable release (80.23.11.321) and there the action list doesn't show in the designer as well.

The Class header as it is now:

    [ToolboxItem(true)]
    [ToolboxBitmap(typeof(ListView))]
    [DefaultEvent("AfterSelect")]
    [DefaultProperty("Nodes")]
    [Designer(typeof(KryptonTreeViewDesigner))]
    [DesignerCategory(@"code")]
    [Description(@"A Kryptonised listview. Does not support the `List or Details View` types")]
    public class KryptonListView : ListView

So the KListview action list works when the Designer is changed to:

    [Designer(typeof(KryptonListViewDesigner))]

I looked back in the history and it has been set to the KTreeviewDesigner ever since.

I there a reason for this or is it a mistake?

Hi @giduac

It was possibly overlooked.

@giduac
Copy link
Contributor

giduac commented May 23, 2024

@JeanPasquini

Would u like to put a new issue or can I describe here and edit the title?

Thanks, it's ok.
No need to change things.
I actually found this as well, we'll handle it in this ticket.
If needed the title and topic start can be adjusted later on when all is complete.

@PWagner1
Copy link
Contributor

Hi @JeanPasquini

If you wish to contribute, all changes must be done on the alpha branch. Documentation can be found here.

@giduac
Copy link
Contributor

giduac commented May 23, 2024

@giduac
Copy link
Contributor

giduac commented May 26, 2024

Hi @JeanPasquini,
The PR has been merged.
If you like you can pull from alpha and see if all works now?

@JeanPasquini
Copy link
Author

Hi @giduac,
Thanks, I'll check later and post here.

@JeanPasquini
Copy link
Author

Hi @giduac,
I checked here and it fixed the bug, thanks.

@giduac
Copy link
Contributor

giduac commented May 28, 2024

Hi @JeanPasquini,
Good to hear, TY.

This fix is also in the latest Nightly build on Nuget.

@giduac
Copy link
Contributor

giduac commented Jun 10, 2024

Hi @JeanPasquini

If you wish to contribute, all changes must be done on the alpha branch. Documentation can be found here.

Hi @JeanPasquini,

Did you have a try working on the toolkit already?
If we can help you getting started, please let us know.

@JeanPasquini
Copy link
Author

Hello @giduac,

I'm developing a software/app using the Krypton Toolkit (https://github.com/JeanPasquini/SpaceCalc), so always when I find a bug or something that I can improve, I'll create an issue or try to fix for you.

@giduac
Copy link
Contributor

giduac commented Jun 10, 2024

Hello @giduac,

I'm developing a software/app using the Krypton Toolkit (https://github.com/JeanPasquini/SpaceCalc), so always when I find a bug or something that I can improve, I'll create an issue or try to fix for you.

Always welcome to join us...

@PWagner1 PWagner1 added fixed This issue has been fixed. and removed under investigation This bug/issue is currently under investigation. labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed This issue has been fixed.
Projects
None yet
Development

No branches or pull requests

3 participants