Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFH: 0.5-style comprehensions broke the way you're using testsets #25

Closed
tkelman opened this issue Jul 13, 2016 · 6 comments
Closed

RFH: 0.5-style comprehensions broke the way you're using testsets #25

tkelman opened this issue Jul 13, 2016 · 6 comments

Comments

@tkelman
Copy link
Contributor

tkelman commented Jul 13, 2016

You might be using @testset for in a more complicated way than most other people? I think there's a base Julia bug here, but I could use a hand in reducing the test case from here. See http://pkg.julialang.org/detail/NearestNeighbors.html

Test Summary: | Pass  Total
  inrange     |   24     24
ERROR: LoadError: LoadError: syntax: break or continue outside loop
 in include_from_node1(::String) at ./loading.jl:426 (repeats 2 times)
 in process_options(::Base.JLOptions) at ./client.jl:266
 in _start() at ./client.jl:322
while loading /home/vagrant/.julia/v0.5/NearestNeighbors/test/test_monkey.jl, in expression starting on line 6
while loading /home/vagrant/.julia/v0.5/NearestNeighbors/test/runtests.jl, in expression starting on line 34

I bisected the failure to Julia commit JuliaLang/julia@cd35df536bd, and I'm pretty sure this is an unintended consequence. Base apparently needs more tests of nested testsets with break/continue in them.

@KristofferC
Copy link
Owner

Interesting. I am at Denver airport right now but will try to make a reduced example in a couple of days when I am home.

@tkelman
Copy link
Contributor Author

tkelman commented Jul 14, 2016

hope you had a good trip

@KristofferC
Copy link
Owner

Was really awesome. Las Vegas -> Zion National Park -> Antelope Canyon -> Grand Canyon -> Monument Valley -> Arches National Park -> Aspen. Now fly to Washington DC and then home.

So much pretty stuff here.. Really amazing.

@tkelman
Copy link
Contributor Author

tkelman commented Jul 16, 2016

maybe related to JuliaLang/julia#17170

@KristofferC
Copy link
Owner

Fixed now

@tkelman
Copy link
Contributor Author

tkelman commented Aug 3, 2016

possibly about to break again ref JuliaLang/julia#17389 (comment), didn't check the log in detail yet though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants